feat: expose brownfield plugin actions & types#666
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
thymikee
force-pushed
the
feat/expose-for-brownfield
branch
from
8a6ed36 to
b76604a
Compare
artus9033
force-pushed
the
feat/expose-for-brownfield
branch
from
32db5e5 to
3fb2d47
Compare
…ork before writing merge output
thymikee
force-pushed
the
feat/expose-for-brownfield
branch
from
3fb2d47 to
071af89
Compare
thymikee
approved these changes
Jan 11, 2026
…plugin to work with non-Rock projects
artus9033
force-pushed
the
feat/expose-for-brownfield
branch
from
f9d3b75 to
48da76a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes and abstracts passing in config for the brownfield plugin to allow Rock-agnostic consumption in the standalone CLI of react-native-brownfield for callstack/react-native-brownfield#176
For clarity of source code, the
FingerprintSourceswas renamed toFingerprintOptionssince this is the most descriptive name (and most parameter names were already namedfingerprintOptions, though of typeFingerprintSources).The PR carries a minor fix to
mergeFrameworksin@rock-js/platform-apple-helpersthat adds a missing piece of debug log that seemed incomplete and didn't log details of what is being removed (in case an output artifact already exists).Ran prettier over the codebase as well.